fix(tweets): limit publishing of tweets based on date#88
Open
tigranstream wants to merge 3 commits intomainfrom
Open
fix(tweets): limit publishing of tweets based on date#88tigranstream wants to merge 3 commits intomainfrom
tigranstream wants to merge 3 commits intomainfrom
Conversation
BrRenat
reviewed
May 24, 2021
src/services/twitter.js
Outdated
| this.publish(saved); | ||
|
|
||
| // Moment throws: value provided is not in a recognized RFC2822 or ISO format, that's why Date constructor is used. | ||
| const tweetDate = moment(new Date(tweet.date)); |
Contributor
There was a problem hiding this comment.
can you show an example of tweet.date?
There was a problem hiding this comment.
@BrRenat I took an example value from here:
https://developer.twitter.com/en/docs/twitter-api/v1/data-dictionary/object-model/tweet
"created_at": "Wed Oct 10 20:19:24 +0000 2018"
There was a problem hiding this comment.
Changed, however I got some warnings for the specified date:
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Contributor
There was a problem hiding this comment.
JFYI
If you know the format of an input string, you can use that to parse a moment.
moment('24/12/2019 09:15:00', "DD MM YYYY hh:mm:ss");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.